-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(mrm_handler): delete control_cmd publish function #6514
Conversation
Signed-off-by: veqcc <[email protected]>
Signed-off-by: veqcc <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6514 +/- ##
==========================================
- Coverage 14.78% 14.78% -0.01%
==========================================
Files 1917 1917
Lines 132012 132017 +5
Branches 39228 39228
==========================================
Hits 19523 19523
- Misses 90699 90704 +5
Partials 21790 21790
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* refactor(mrm_handler): delete control_cmd publish function Signed-off-by: veqcc <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
…oundation#6514) * refactor(mrm_handler): delete control_cmd publish function Signed-off-by: veqcc <[email protected]> Signed-off-by: kaigohirao <[email protected]>
…oundation#6514) * refactor(mrm_handler): delete control_cmd publish function Signed-off-by: veqcc <[email protected]>
…oundation#6514) * refactor(mrm_handler): delete control_cmd publish function Signed-off-by: veqcc <[email protected]>
Description
Since
publishControlCmd
function no longer publishescontrol_cmd
, it was a misleading name.Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.